fix: update antlr4 CMAKE_POLICY from OLD to NEW for CMake 3.31+#145
Merged
Cuiyus merged 2 commits intoalibaba:mainfrom Feb 27, 2026
Merged
Conversation
…tibility CMake 3.31+ has removed support for the OLD behavior of policies CMP0042, CMP0045, CMP0054, and CMP0059. This causes a hard configuration error when building from source with newer CMake versions. Changing these to NEW resolves the build failure. The NEW behavior has been the default since CMake 3.0/3.3 and does not affect functionality. Fixes alibaba#144
|
|
Collaborator
|
@greptile |
Greptile SummaryThis PR fixes a critical build compatibility issue with CMake 3.31+ by updating the antlr4 patch to use NEW behavior for four CMake policies (CMP0042, CMP0045, CMP0054, CMP0059) instead of the now-unsupported OLD behavior. These policies were deprecated in CMake 3.0/3.3 and support for OLD was removed in CMake 3.31, causing build failures.
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 9faf384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
antlr4.patchto changeCMAKE_POLICY(SET ... OLD)toNEWfor policies CMP0042, CMP0045, CMP0054, and CMP0059OLDbehavior of these policies, causing a hard configuration error when building from sourceDetails
The
OLDbehavior for these policies has been deprecated since CMake 3.0/3.3 and was fully removed in CMake 3.31. Changing toNEWresolves the build failure without affecting functionality sinceNEWhas been the default behavior for years.Edit
Note: This fix resolves the CMake 3.31+ configuration error but does not address the separate RocksDB 8.1.1
compilation failure with GCC 15 (see #144 for details). Users on GCC 15 will still need to build with GCC 14 or
earlier (e.g., via the
python:3.12Docker image) until RocksDB is upgraded.Test plan
python:3.12Docker image (GCC 14, CMake 3.31.10)import zvecworks correctly after installationFixes #144